Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Full plan CSE #15264

Merged
merged 18 commits into from
Mar 26, 2024
Merged

feat: Full plan CSE #15264

merged 18 commits into from
Mar 26, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@ritchie46 ritchie46 marked this pull request as draft March 24, 2024 09:18
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 24, 2024
@ritchie46 ritchie46 changed the title feat: Full plan CSE [skip ci] feat: Full plan CSE Mar 24, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 85.90492% with 169 lines in your changes are missing coverage. Please review.

Project coverage is 81.34%. Comparing base (2fca551) to head (837039f).
Report is 8 commits behind head on main.

Files Patch % Lines
...rates/polars-plan/src/logical_plan/visitor/hash.rs 79.11% 80 Missing ⚠️
crates/polars-plan/src/logical_plan/alp/schema.rs 49.25% 34 Missing ⚠️
...ates/polars-plan/src/logical_plan/functions/mod.rs 36.11% 23 Missing ⚠️
...lars-plan/src/logical_plan/optimizer/cse/cse_lp.rs 93.62% 13 Missing ⚠️
...c/logical_plan/optimizer/predicate_pushdown/mod.rs 97.60% 5 Missing ⚠️
crates/polars-core/src/schema.rs 0.00% 3 Missing ⚠️
crates/polars-plan/src/logical_plan/alp/mod.rs 0.00% 3 Missing ⚠️
crates/polars-plan/src/logical_plan/visitor/lp.rs 50.00% 3 Missing ⚠️
...rs-plan/src/logical_plan/optimizer/cache_states.rs 97.61% 2 Missing ⚠️
...olars-plan/src/logical_plan/optimizer/cse/cache.rs 96.87% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15264      +/-   ##
==========================================
+ Coverage   81.31%   81.34%   +0.02%     
==========================================
  Files        1359     1363       +4     
  Lines      176083   176568     +485     
  Branches     2524     2526       +2     
==========================================
+ Hits       143188   143632     +444     
- Misses      32411    32452      +41     
  Partials      484      484              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 marked this pull request as ready for review March 25, 2024 19:29
@ritchie46 ritchie46 added the highlight Highlight this PR in the changelog label Mar 25, 2024
@ritchie46 ritchie46 merged commit a9f4df3 into main Mar 26, 2024
18 checks passed
@ritchie46 ritchie46 deleted the cse_lp branch March 26, 2024 07:47
@c-peters c-peters added the accepted Ready for implementation label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature highlight Highlight this PR in the changelog python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants