Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Handle special case correctly when slicing a LazyFrame #15297

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

petrosbar
Copy link
Contributor

When sliced with the object slice(0, None, -1), LazyFrame returns incorrect result.

Fixes #15295

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (705b148) to head (d9968dd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15297      +/-   ##
==========================================
+ Coverage   81.32%   81.34%   +0.01%     
==========================================
  Files        1360     1364       +4     
  Lines      176070   176566     +496     
  Branches     2526     2526              
==========================================
+ Hits       143183   143621     +438     
- Misses      32403    32461      +58     
  Partials      484      484              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Thank you for the fix!

@ritchie46 ritchie46 merged commit 2774bbb into pola-rs:main Mar 26, 2024
12 checks passed
@petrosbar petrosbar deleted the bug-lazy-slice branch March 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect result returned from LazyFrame when sliced
2 participants