feat(python): In hypothesis testing strategies, enable Decimal strategy by default #15321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
stinodego
commented
Mar 27, 2024
| @@ -10,24 +10,6 @@ | |||
| from polars.testing import assert_series_equal | |||
| from polars.testing.parametric import series | |||
|
|
|||
| # TODO: once Decimal is a little further along, start actively probing it | |||
There was a problem hiding this comment.
I removed this TODO, because we already have tests for to_list, and for the strategy itself. More tests are always welcome, but don't have to be a TODO like this.
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
|
Good to see... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling this already helped me catch a bug. Let's enable it by default - our Decimals are a lot better supported already.