chore: remove try_apply_values #15336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlp
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
github-actions
bot
added
internal
ritchie46
approved these changes
Mar 27, 2024
|
Good to go, needs a rebase. |
orlp
force-pushed
the
remove-try-apply-values
branch
from
6d2213a
to
1ad57f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was essentially impossible to use correctly, as we would not want to propagate errors generated from mapping the values behind nulls.