Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Enforce integer dtype input for int_range and int_ranges #15339

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

stinodego
Copy link
Member

Closes #15307

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Mar 27, 2024
@stinodego stinodego marked this pull request as ready for review March 27, 2024 17:48
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (1f3e1c4) to head (6f1ca77).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15339      +/-   ##
==========================================
+ Coverage   81.35%   81.36%   +0.01%     
==========================================
  Files        1364     1364              
  Lines      176655   176673      +18     
  Branches     2531     2531              
==========================================
+ Hits       143721   143757      +36     
+ Misses      32448    32431      -17     
+ Partials      486      485       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 9fca017 into main Mar 27, 2024
15 checks passed
@stinodego stinodego deleted the int-range-fix branch March 27, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pl.int_range() panicks when dtype=pl.String, and is inconsistent with pl.int_ranges()
1 participant