-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: to_any_value
should supports all LiteralValue type
#15387
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15387 +/- ##
==========================================
- Coverage 81.41% 81.25% -0.17%
==========================================
Files 1362 1361 -1
Lines 176734 174738 -1996
Branches 2531 2531
==========================================
- Hits 143896 141985 -1911
+ Misses 32354 32269 -85
Partials 484 484 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should instead implement to_any_value
for the missing types. Should be easy enough - Series and Range become a List type AnyValue, and Binary becomes a Binary AnyValue.
Emm, that's what I thought at first, but I wasn't sure whether this conversion is clear in all cases or not? Because But I have updated this anyway, let's see if CI is broken then. :) |
pl.repeat
raise instead of panic if dtype can't be inferredto_any_value
should supports all LiteralValue type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice that we can use repeat
on list inputs now 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice that we can use repeat
on list inputs now 👌
Thanks @stinodego, do you think I can click the merge button atm? 😉 |
This fixes #15379.