-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust, python): Add null_on_oob
parameter to expr.list.get
#15395
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15395 +/- ##
==========================================
- Coverage 81.37% 81.14% -0.24%
==========================================
Files 1363 1361 -2
Lines 176803 174683 -2120
Branches 2531 2531
==========================================
- Hits 143869 141738 -2131
- Misses 32449 32459 +10
- Partials 485 486 +1 ☔ View full report in Codecov by Sentry. |
It looks like we changed the default behavior of |
Yes, we shouldn't change the default behaviour yet. We can do that after all operations in #15240 f are supported and we go to 1.0. |
@JamesCE2001 can you default to |
Done, apologies for jumping the gun. Updated original PR comment to reflect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @JamesCE2001.Thank you!
Addresses first part of #15240 (first time contributing so I figured I'd add 1 and get feedback before embarking on the rest, especially as they don't seem to overlap as much as I'd expected.)
For now leaves the default behavior to
null_on_oob=True
(see discussion below; we will revisit the default behavior for once it has been implemented for all functions in #15240).