Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Make LogicalPlan immutable #15416

Merged
merged 1 commit into from
Apr 1, 2024
Merged

perf: Make LogicalPlan immutable #15416

merged 1 commit into from
Apr 1, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Apr 1, 2024 •
edited
Loading

Started by @orlp for expressions. This finishes it for the LogicalPlan DSL. Query building performance in Python is now O(1) instead of O(n^2).

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 1, 2024
@ritchie46 ritchie46 merged commit 758b55a into main Apr 1, 2024
20 checks passed
@ritchie46 ritchie46 deleted the lp branch April 1, 2024 12:23
@c-peters c-peters added the accepted Ready for implementation label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@ritchie46 ritchie46

Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @c-peters