-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust, python): pow
return type evaluation
#15506
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15506 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 1362 1362
Lines 174951 174931 -20
Branches 2533 2531 -2
=======================================
- Hits 141960 141954 -6
+ Misses 32508 32494 -14
Partials 483 483 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @CanglongCl. Thank you.
If exponent is float, it follows dtype of exponent. Otherwise, it follows dtype of base. See: pola-rs/polars#15506
fix comment of #12129.
Now dtype of series returned from
pow
will be evaluate:If
exponent
is float, it follows dtype ofexponent
. Otherwise, it follows dtype ofbase
.The behavior is the same as
pow
in python std lib andpow
innum_trait
.