-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add business_day_count function #15512
Conversation
083bc31
to
999a70c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15512 +/- ##
==========================================
+ Coverage 81.12% 81.14% +0.01%
==========================================
Files 1363 1368 +5
Lines 175161 175290 +129
Branches 2527 2527
==========================================
+ Hits 142108 142244 +136
+ Misses 32575 32568 -7
Partials 478 478 ☔ View full report in Codecov by Sentry. |
0956d8c
to
4c87c16
Compare
.github/licenses/NUMPY_LICENSE.txt
Outdated
Copyright (c) 2005-2023, NumPy Developers. | ||
All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could lead to problems as we want to distribute as MIT/Apache. But I also don't believe this required. You have interpreted their source code and written it as Rust. I think a link with credits should suffice.
This is the most basic case: count the number of weekdays between two dates
I'd like to suggest starting with this one, and then considering the following as follow-ups:
week_mask
andholidays
argsadd_business_day
functionis_business_day
functionThis functionality is pretty much a port of NumPy's
busday_count
, so as required I've included their license. Separate to this PR, but a few other licenses should probably be included toostatus: I'm trying to sort out the structure, moving the implementation tohappy for this to be reviewedpolars-ops
as that's where most functions seem to be implemented