Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Organize utils for I/O functionality #15529

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Apr 7, 2024

Just some light refactoring.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Apr 7, 2024
@stinodego stinodego marked this pull request as ready for review April 7, 2024 22:57
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 94.25287% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.16%. Comparing base (49e4244) to head (42b5b1f).

Files Patch % Lines
py-polars/polars/io/spreadsheet/functions.py 50.00% 1 Missing and 1 partial ⚠️
py-polars/polars/io/parquet/anonymous_scan.py 50.00% 0 Missing and 1 partial ⚠️
py-polars/polars/io/parquet/functions.py 75.00% 0 Missing and 1 partial ⚠️
py-polars/polars/io/spreadsheet/_utils.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15529      +/-   ##
==========================================
- Coverage   81.16%   81.16%   -0.01%     
==========================================
  Files        1362     1363       +1     
  Lines      175001   175009       +8     
  Branches     2532     2532              
==========================================
+ Hits       142037   142040       +3     
- Misses      32481    32487       +6     
+ Partials      483      482       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit afe04a5 into main Apr 8, 2024
14 checks passed
@stinodego stinodego deleted the util-refactor branch April 8, 2024 05:51
@c-peters c-peters added the accepted Ready for implementation label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants