Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: join by row-encoding #15559

Merged
merged 3 commits into from
Apr 10, 2024
Merged

perf: join by row-encoding #15559

merged 3 commits into from
Apr 10, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Apr 9, 2024

  • Adds join validation for multiple keys.
  • Faster multiple key joins
  • Negative code count

closes #2377

(note to self, many_bitmap_and_combine and boolean unary without chain).

@ritchie46 ritchie46 changed the title join by row-encoding perf: join by row-encoding Apr 9, 2024
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 9, 2024
Copy link

codspeed-hq bot commented Apr 9, 2024

CodSpeed Performance Report

Merging #15559 will not alter performance

Comparing join (34188ae) with main (b91dedb)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 97.65625% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 81.08%. Comparing base (42d3697) to head (34188ae).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/polars-ops/src/frame/join/mod.rs 93.15% 5 Missing ⚠️
crates/polars-core/src/chunked_array/float.rs 66.66% 3 Missing ⚠️
crates/polars-ops/src/frame/join/asof/groups.rs 98.64% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15559      +/-   ##
==========================================
- Coverage   81.15%   81.08%   -0.08%     
==========================================
  Files        1367     1367              
  Lines      175313   174858     -455     
  Branches     2530     2530              
==========================================
- Hits       142283   141783     -500     
- Misses      32555    32601      +46     
+ Partials      475      474       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8f40509 into main Apr 10, 2024
20 checks passed
@ritchie46 ritchie46 deleted the join branch April 10, 2024 05:50
mbuhidar pushed a commit to mbuhidar/polars that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional validation output to joins
1 participant