Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't use dynamic dispatch in visitors #15607

Merged
merged 1 commit into from
Apr 12, 2024
Merged

perf: don't use dynamic dispatch in visitors #15607

merged 1 commit into from
Apr 12, 2024

Conversation

ritchie46
Copy link
Member

Might help: #15551

We could hopefully get a more useful flamegraph at least.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 12, 2024
@ritchie46 ritchie46 merged commit 5e74924 into main Apr 12, 2024
19 checks passed
@ritchie46 ritchie46 deleted the visitor branch April 12, 2024 06:50
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #15607 will not alter performance

Comparing visitor (43ace53) with main (c8e26ca)

Summary

✅ 22 untouched benchmarks

@c-peters c-peters added the accepted Ready for implementation label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@ritchie46 ritchie46

Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @c-peters