Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make json_path_match expr non-anonymous #15682

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Apr 16, 2024

Caught a fish that slipped through the net. 😉

The next step is to expressify this one.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Apr 16, 2024
@reswqa reswqa marked this pull request as ready for review April 16, 2024 03:51
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15682 will not alter performance

Comparing reswqa:json_path (ef9c970) with main (5e68541)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (70b71da) to head (ef9c970).

Files Patch % Lines
...rates/polars-plan/src/dsl/function_expr/strings.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15682      +/-   ##
==========================================
- Coverage   81.33%   81.33%   -0.01%     
==========================================
  Files        1374     1374              
  Lines      176471   176472       +1     
  Branches     2544     2544              
==========================================
- Hits       143539   143537       -2     
- Misses      32450    32452       +2     
- Partials      482      483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Just a few left. 👀

@ritchie46 ritchie46 merged commit b338076 into pola-rs:main Apr 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants