Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust!): Rename LogicalPlan and builders to reflect their uses better #15712

Merged
merged 4 commits into from
Apr 17, 2024
Merged

refactor(rust!): Rename LogicalPlan and builders to reflect their uses better #15712

merged 4 commits into from
Apr 17, 2024

Conversation

ritchie46
Copy link
Member

LogicalPlan -> DslPlan

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars labels Apr 17, 2024
@ritchie46 ritchie46 merged commit e218203 into main Apr 17, 2024
24 checks passed
@ritchie46 ritchie46 deleted the lp branch April 17, 2024 07:19
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 17, 2024

CodSpeed Performance Report

Merging #15712 will not alter performance

Comparing lp (ed80e14) with main (2ac0da2)

Summary

✅ 22 untouched benchmarks

@c-peters c-peters added the accepted Ready for implementation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@ritchie46 ritchie46

Labels
accepted Ready for implementation breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @c-peters