Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass series name to apply for cut/qcut #15715

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Apr 17, 2024

We should pass the name to apply, otherwise the name of bin column will be _bin.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 17, 2024
@reswqa reswqa changed the title fix: pass series name for Qcut/QcutUniform fix: pass series name to apply for cut/qcut Apr 17, 2024
@reswqa reswqa marked this pull request as ready for review April 17, 2024 09:41
Copy link

codspeed-hq bot commented Apr 17, 2024

CodSpeed Performance Report

Merging #15715 will improve performances by 11.29%

Comparing reswqa:cut (0c0e086) with main (e39ba62)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark main reswqa:cut Change
test_boolean_min_max_agg 17.1 ms 15.4 ms +11.29%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants