feat: Add typed collection from par iterators #15961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
ritchie46
commented
Apr 30, 2024
| // })? | ||
| let out: ListChunked = POOL.install(|| iter.collect::<PolarsResult<_>>())?; | ||
|
|
||
| #[cfg(debug_assertions)] |
There was a problem hiding this comment.
Currently not enforced yet in release. Will make the switch after a while.
ritchie46
commented
Apr 30, 2024
| @@ -459,16 +459,6 @@ pub fn repeat(value: PyExpr, n: PyExpr, dtype: Option<Wrap<DataType>>) -> PyResu | |||
| value = value.cast(dtype.0); | |||
| } | |||
|
|
|||
| if let Expr::Literal(lv) = &value { | |||
There was a problem hiding this comment.
This should be left to dynamic int.
CodSpeed Performance ReportMerging #15961 will improve performances by 24.86%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15961 +/- ##
==========================================
+ Coverage 81.29% 81.33% +0.04%
==========================================
Files 1381 1381
Lines 176855 176955 +100
Branches 3042 3043 +1
==========================================
+ Hits 143766 143927 +161
+ Misses 32606 32545 -61
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure we keep the
dtypeequal to the schema.