Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move diagonal & horizontal concat schema resolving to IR phase #16034

Merged
merged 5 commits into from
May 3, 2024

Conversation

ritchie46
Copy link
Member

This also make diagonal concat faster as we did mutliple with_columns sequentially. Now they are batched.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels May 3, 2024
@@ -52,7 +52,6 @@ pub enum IR {
SimpleProjection {
input: Node,
columns: SchemaRef,
duplicate_check: bool,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this as a Schema cannot have multiple columns.

@ritchie46 ritchie46 changed the title feat: Move diagonal concat schema resolving to IR phase feat: Move diagonal & horizontal concat schema resolving to IR phase May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 96.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.91%. Comparing base (222216a) to head (0f4f5ec).
Report is 2 commits behind head on main.

❗ Current head 0f4f5ec differs from pull request most recent head 92e48d0. Consider uploading reports for the commit 92e48d0 to get more accurate results

Files Patch % Lines
py-polars/src/lazyframe/visitor/nodes.rs 0.00% 2 Missing ⚠️
...-plan/src/logical_plan/conversion/convert_utils.rs 98.36% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16034   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files        1385     1385           
  Lines      178244   178229   -15     
  Branches     3050     3050           
=======================================
- Hits       144229   144218   -11     
+ Misses      33526    33521    -5     
- Partials      489      490    +1     
Flag Coverage Δ
python 74.39% <96.25%> (-0.01%) ⬇️
rust 78.13% <96.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 5da378f into main May 3, 2024
25 checks passed
@ritchie46 ritchie46 deleted the schema branch May 3, 2024 11:47
@c-peters c-peters added the accepted Ready for implementation label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants