-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move diagonal & horizontal concat schema resolving to IR phase #16034
Conversation
@@ -52,7 +52,6 @@ pub enum IR { | |||
SimpleProjection { | |||
input: Node, | |||
columns: SchemaRef, | |||
duplicate_check: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this as a Schema
cannot have multiple columns.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16034 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 1385 1385
Lines 178244 178229 -15
Branches 3050 3050
=======================================
- Hits 144229 144218 -11
+ Misses 33526 33521 -5
- Partials 489 490 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This also make diagonal concat faster as we did mutliple
with_columns
sequentially. Now they are batched.