Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix printing max scale decimals #16048

Merged
merged 2 commits into from
May 4, 2024
Merged

fix: Fix printing max scale decimals #16048

merged 2 commits into from
May 4, 2024

Conversation

stinodego
Copy link
Member

I'm improving the parametric tests and finding lots of edge cases as I go along... :)

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (e84fe69) to head (edb4410).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16048   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files        1386     1386           
  Lines      178385   178385           
  Branches     3060     3060           
=======================================
+ Hits       144422   144430    +8     
+ Misses      33475    33466    -9     
- Partials      488      489    +1     
Flag Coverage Δ
python 74.52% <ø> (+0.02%) ⬆️
rust 78.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit e17ef46 into main May 4, 2024
26 checks passed
@stinodego stinodego deleted the fix-decimal-print branch May 4, 2024 19:58
@c-peters c-peters added the accepted Ready for implementation label May 6, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants