Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Use Duration.is_zero instead of comparing Duration.duration_ns to 0 #16195

Merged
merged 1 commit into from
May 13, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels May 13, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 13, 2024 14:15
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (2e00647) to head (5072a64).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16195      +/-   ##
==========================================
- Coverage   81.00%   80.99%   -0.01%     
==========================================
  Files        1392     1392              
  Lines      178943   178930      -13     
  Branches     2901     2904       +3     
==========================================
- Hits       144947   144930      -17     
- Misses      33491    33497       +6     
+ Partials      505      503       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks good, thanks!

@stinodego stinodego changed the title chore(rust): use Duration.is_zero instead of comparing Duration.duration_ns to 0 chore(rust): Use Duration.is_zero instead of comparing Duration.duration_ns to 0 May 13, 2024
@stinodego stinodego merged commit 9bfa30c into pola-rs:main May 13, 2024
22 checks passed
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants