Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix a rounding error in parametric test datetimes generation #16228

Merged
merged 2 commits into from
May 14, 2024

Conversation

stinodego
Copy link
Member

I didn't account for the fact that Python floordiv rounds away from zero in negative numbers.

Also moving a constant that was only used in tests to a test fixture.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (004efbe) to head (c21c7df).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16228   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files        1394     1393    -1     
  Lines      179564   179568    +4     
  Branches     2908     2909    +1     
=======================================
+ Hits       145329   145335    +6     
+ Misses      33730    33728    -2     
  Partials      505      505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 79a2cf1 into main May 14, 2024
15 checks passed
@stinodego stinodego deleted the fix-strat-rounding-err branch May 14, 2024 23:31
MarcoGorelli pushed a commit to MarcoGorelli/polars that referenced this pull request May 15, 2024
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants