Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Use CsvReadOptions in LazyCsvReader #16283

Merged
merged 6 commits into from
May 17, 2024

Conversation

nameexhaustion
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels May 17, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review May 17, 2024 04:49
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.80%. Comparing base (11fe9d8) to head (f198d1e).

Files Patch % Lines
crates/polars-lazy/src/scan/csv.rs 91.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16283      +/-   ##
==========================================
- Coverage   80.80%   80.80%   -0.01%     
==========================================
  Files        1393     1393              
  Lines      179406   179315      -91     
  Branches     2921     2921              
==========================================
- Hits       144971   144888      -83     
+ Misses      33932    33924       -8     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit cc13820 into pola-rs:main May 17, 2024
21 checks passed
@nameexhaustion nameexhaustion deleted the lazy-csv-reader branch May 17, 2024 06:41
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants