Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Move DataFrame.to_numpy implementation to Rust side #16354

Merged
merged 6 commits into from
May 21, 2024

Conversation

stinodego
Copy link
Contributor

Ref #14334

This is required to facilitate recursive handling of Structs.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 95.86207% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.38%. Comparing base (1cdab6f) to head (50ff4d5).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/src/interop/numpy/to_numpy_df.rs 96.94% 4 Missing ⚠️
py-polars/src/interop/numpy/to_numpy_series.rs 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16354   +/-   ##
=======================================
  Coverage   81.37%   81.38%           
=======================================
  Files        1405     1405           
  Lines      183738   183809   +71     
  Branches     2957     2953    -4     
=======================================
+ Hits       149525   149591   +66     
- Misses      33700    33705    +5     
  Partials      513      513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review May 21, 2024 10:00
@ritchie46 ritchie46 merged commit 5e6a433 into main May 21, 2024
19 checks passed
@ritchie46 ritchie46 deleted the move-np-df branch May 21, 2024 10:34
@c-peters c-peters added the accepted Ready for implementation label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants