Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Use strings to expose ClosedInterval in expr IR #16369

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(python): Use strings to expose ClosedInterval in expr IR #16369

merged 1 commit into from
May 21, 2024

Conversation

wence-
Copy link
Collaborator

@wence- wence- commented May 21, 2024

No description provided.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels May 21, 2024
@ritchie46
Copy link
Member

Maybe we should just use string on this one? Saves compiler bloat.

@codecov Codecov
Copy link

codecov bot commented May 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.38%. Comparing base (6289dc3) to head (e25be50).
Report is 3 commits behind head on main.

Files Patch % Lines
py-polars/src/lazyframe/visitor/expr_nodes.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16369   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files        1406     1406           
  Lines      183911   183909    -2     
  Branches     2953     2953           
=======================================
- Hits       149671   149670    -1     
+ Misses      33727    33726    -1     
  Partials      513      513

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wence-
Copy link
Collaborator Author

wence- commented May 21, 2024

Maybe we should just use string on this one? Saves compiler bloat.

Can do if you prefer?

@wence-
fix(python): Use strings for ClosedInterval
e25be50 
It's not worth making a struct here.
@wence- wence- force-pushed the wence/fix/closedinterval-pyexpr branch from b8d8fa1 to e25be50 Compare May 21, 2024 16:21
@wence-
Copy link
Collaborator Author

wence- commented May 21, 2024

Maybe we should just use string on this one? Saves compiler bloat.

Can do if you prefer?

Done.

@wence- wence- changed the title fix(python): fix name in PyClosedInterval and add hash impl fix(python): Use strings to expose ClosedInterval in expr IR May 21, 2024
@ritchie46 ritchie46 merged commit c334c70 into pola-rs:main May 21, 2024
18 checks passed
@wence- wence- deleted the wence/fix/closedinterval-pyexpr branch May 21, 2024 20:54
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@wence- @Wouittone
fix(python): Use strings to expose ClosedInterval in expr IR (pola-…
b03744d 
…rs#16369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @ritchie46