Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Update __array__ method for Series and DataFrame to support copy parameter #16401

Merged
merged 2 commits into from
May 23, 2024

Conversation

stinodego
Copy link
Contributor

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels May 22, 2024
@stinodego stinodego changed the title feat(python): Update __array__ method for Series and DataFrame feat(python): Update __array__ method for Series and DataFrame to support copy parameter May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 81.44%. Comparing base (3d9ef69) to head (ebcae52).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/polars/dataframe/frame.py 37.50% 8 Missing and 2 partials ⚠️
py-polars/polars/series/series.py 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16401      +/-   ##
==========================================
- Coverage   81.45%   81.44%   -0.02%     
==========================================
  Files        1409     1409              
  Lines      184567   184591      +24     
  Branches     2962     2970       +8     
==========================================
- Hits       150333   150332       -1     
- Misses      33718    33740      +22     
- Partials      516      519       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review May 22, 2024 17:07
@ritchie46 ritchie46 merged commit ff1e885 into main May 23, 2024
14 checks passed
@ritchie46 ritchie46 deleted the array-method branch May 23, 2024 06:14
@c-peters c-peters added the accepted Ready for implementation label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants