Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Fewer typing.no_type_check #16497

Merged
merged 2 commits into from
May 26, 2024

Conversation

twoertwein
Copy link
Contributor

Some of the code uses -> None for __init__: I put the change to require None in a separate commit to make it easy to revert if needed.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (5b25fb8) to head (c2dc2b5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16497   +/-   ##
=======================================
  Coverage   81.51%   81.52%           
=======================================
  Files        1410     1410           
  Lines      185032   185061   +29     
  Branches     2981     2982    +1     
=======================================
+ Hits       150829   150866   +37     
+ Misses      33687    33679    -8     
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add the flake8-annotations lint. MyPy already requires everything to have a type signature as we run it in strict mode.

__init__ needing to return None is something Guido van Rossom explicitly mentioned was clutter and I agree, so I wouldn't want to add those annotations.

The fixups of the no untyped def ignores and no_type_check decorator removals are welcome though!

@twoertwein twoertwein changed the title refactor(python): require type annotations (flake8-annotations) refactor(python): fewer typing.no_type_check May 26, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stinodego stinodego changed the title refactor(python): fewer typing.no_type_check refactor(python): Fewer typing.no_type_check May 26, 2024
@stinodego stinodego merged commit d856b49 into pola-rs:main May 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants