Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Expose temporal function expression ops to expr ir #16546

Merged
merged 2 commits into from
May 28, 2024

Conversation

wence-
Copy link
Collaborator

@wence- wence- commented May 28, 2024

Also align a few more of the string names with the name used in the expression API that eventually leads to construction of these nodes.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 1.23457% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 81.47%. Comparing base (27c6dcd) to head (83a540d).
Report is 3 commits behind head on main.

Current head 83a540d differs from pull request most recent head 494fa9c

Please upload reports for the commit 494fa9c to get more accurate results.

Files Patch % Lines
py-polars/src/lazyframe/visitor/expr_nodes.rs 0.00% 80 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16546      +/-   ##
==========================================
- Coverage   81.50%   81.47%   -0.04%     
==========================================
  Files        1412     1412              
  Lines      185246   185210      -36     
  Branches     2985     2987       +2     
==========================================
- Hits       150987   150892      -95     
- Misses      33741    33800      +59     
  Partials      518      518              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wence- wence- force-pushed the wence/fea/temporal-pyexpr branch from 83a540d to 494fa9c Compare May 28, 2024 11:16
@ritchie46 ritchie46 merged commit 52c919f into pola-rs:main May 28, 2024
27 checks passed
@wence- wence- deleted the wence/fea/temporal-pyexpr branch May 28, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants