fix: Error selecting columns after non-coalesced join (multiple join keys) #16559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
May 29, 2024
| @@ -97,7 +97,7 @@ pub(super) fn process_asof_join( | |||
|
|
|||
| // The join on keys can lead that columns are already added, we don't want to create | |||
| // duplicates so store the names. | |||
| let mut already_added_local_to_local_projected = BTreeSet::new(); | |||
| let mut local_projected_names = BTreeSet::new(); | |||
There was a problem hiding this comment.
simplify this variable name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16559 +/- ##
==========================================
+ Coverage 81.46% 81.48% +0.02%
==========================================
Files 1412 1412
Lines 185465 185476 +11
Branches 2996 2996
==========================================
+ Hits 151084 151143 +59
+ Misses 33865 33817 -48
Partials 516 516 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16554