Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix parsing of shape in Array constructor and deprecate width parameter #16567

Merged
merged 7 commits into from
May 30, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 29, 2024

Changes

  • Fixed a recursion issue where the shape of the Array type was constructed backwards, e.g. input (1,2,3,4) would result in an actual shape (1,4,3,2).
  • Deprecated the width input and the width attribute.
  • Update the repr to always show a shape, instead of showing size=... on one-dimensional Arrays.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.49%. Comparing base (4dc17d9) to head (4117a52).
Report is 4 commits behind head on main.

Files Patch % Lines
py-polars/polars/datatypes/classes.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16567      +/-   ##
==========================================
+ Coverage   81.47%   81.49%   +0.01%     
==========================================
  Files        1412     1414       +2     
  Lines      185476   185535      +59     
  Branches     2996     2997       +1     
==========================================
+ Hits       151118   151196      +78     
+ Misses      33842    33824      -18     
+ Partials      516      515       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f1be8d9 into main May 30, 2024
14 checks passed
@ritchie46 ritchie46 deleted the depr-dtype-array-width branch May 30, 2024 08:41
@c-peters c-peters added the accepted Ready for implementation label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants