depr(python): Rename Series.equals parameter strict to check_dtypes and rename assertion utils parameter check_dtype to check_dtypes
#16573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deprecation
stinodego
force-pushed
the
fix-assert-behavior
branch
from
d3db443 to
49a111d
Compare
stinodego
commented
May 29, 2024
| @@ -34,7 +34,7 @@ impl Series { | |||
| && { | |||
| let eq = self.equal_missing(other); | |||
| match eq { | |||
| Ok(b) => b.sum().map(|s| s as usize).unwrap_or(0) == self.len(), | |||
| Ok(b) => b.all(), | |||
There was a problem hiding this comment.
Drive-by change - this should be more efficient.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16573 +/- ##
==========================================
- Coverage 81.49% 81.48% -0.01%
==========================================
Files 1414 1414
Lines 185561 185568 +7
Branches 2997 3002 +5
==========================================
- Hits 151219 151209 -10
- Misses 33826 33843 +17
Partials 516 516 ☔ View full report in Codecov by Sentry. |
stinodego
changed the title
strict to check_dtype in Series.equals and rename check_names to check_name in assert_series_equalSeries.equals parameter strict to check_dtypes and rename assertion utils parameter check_dtype to check_dtypes
stinodego
force-pushed
the
fix-assert-behavior
branch
from
49a111d to
2c08342
Compare
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13231
Changes
check_dtypetocheck_dtypes. This better matches the other parametercheck_names(plural). I considered changingcheck_namestocheck_nameinstead, but plural makes more sense here.Series.equals, renamestrictparameter tocheck_dtypes. This aligns withassert_series_equaland is much clearer.