Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr(python): Deprecate nulls_last/maintain_order/multithreaded parameters for top_k methods #16597

Merged
merged 7 commits into from
May 30, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 30, 2024

These parameters were unreliable at best. We are stripping these away and taking a fresh start with 1.0.

@github-actions github-actions bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels May 30, 2024
@stinodego stinodego marked this pull request as ready for review May 30, 2024 13:32
@stinodego stinodego merged commit dbfa051 into main May 30, 2024
15 checks passed
@stinodego stinodego deleted the depr-topk branch May 30, 2024 13:54
@c-peters c-peters added the accepted Ready for implementation label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants