Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Add split_at method to arrow Array #16620

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

coastalwhite
Copy link
Collaborator

This adds a split_at and split_at_unchecked method to each type that implements the Array trait. This is done under the Splitable trait.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 83.52601% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 81.50%. Comparing base (d190e02) to head (cf3a8c0).
Report is 10 commits behind head on main.

Current head cf3a8c0 differs from pull request most recent head b473cb9

Please upload reports for the commit b473cb9 to get more accurate results.

Files Patch % Lines
crates/polars-core/src/chunked_array/object/mod.rs 0.00% 27 Missing ⚠️
crates/polars-arrow/src/array/null.rs 0.00% 15 Missing ⚠️
crates/polars-arrow/src/array/binview/mod.rs 76.31% 9 Missing ⚠️
crates/polars-arrow/src/array/mod.rs 87.09% 4 Missing ⚠️
crates/polars-arrow/src/bitmap/immutable.rs 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16620      +/-   ##
==========================================
- Coverage   81.51%   81.50%   -0.01%     
==========================================
  Files        1414     1414              
  Lines      185714   186252     +538     
  Branches     3008     3027      +19     
==========================================
+ Hits       151385   151810     +425     
- Misses      33813    33911      +98     
- Partials      516      531      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite marked this pull request as draft May 31, 2024 10:00
@coastalwhite coastalwhite marked this pull request as ready for review May 31, 2024 10:36
@coastalwhite coastalwhite force-pushed the arrow-array-split-at branch 3 times, most recently from 841b607 to 827112a Compare May 31, 2024 12:48
@ritchie46 ritchie46 merged commit ae70fd4 into pola-rs:main Jun 1, 2024
21 checks passed
@coastalwhite coastalwhite deleted the arrow-array-split-at branch June 1, 2024 06:56
@c-peters c-peters added the accepted Ready for implementation label Jun 3, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants