Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Reduce scope of multi-threaded numpy conversion #16686

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

ritchie46
Copy link
Member

Only when we cannot move zero-copy. We catch the FileNotFound error and recurse without multithreading if failed.

fixes #16675

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.45%. Comparing base (15981d7) to head (472565d).

Files Patch % Lines
py-polars/polars/_utils/construction/dataframe.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16686      +/-   ##
==========================================
- Coverage   81.47%   81.45%   -0.02%     
==========================================
  Files        1416     1416              
  Lines      186884   186887       +3     
  Branches     3021     3021              
==========================================
- Hits       152257   152224      -33     
- Misses      34094    34131      +37     
+ Partials      533      532       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 0b18f89 into main Jun 3, 2024
15 checks passed
@ritchie46 ritchie46 deleted the lambda branch June 3, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create polars dataframes on AWS Lambda
1 participant