Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Handle nested categoricals in assert_series_equal when categorical_as_str=True #16700

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

stinodego
Copy link
Member

Closes #16196

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jun 3, 2024
@stinodego stinodego marked this pull request as ready for review June 3, 2024 23:09
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.47%. Comparing base (c506d1f) to head (bd063e7).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/polars/testing/asserts/series.py 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16700   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files        1416     1416           
  Lines      186889   186922   +33     
  Branches     3021     3029    +8     
=======================================
+ Hits       152259   152298   +39     
+ Misses      34097    34090    -7     
- Partials      533      534    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 734890b into main Jun 4, 2024
15 checks passed
@ritchie46 ritchie46 deleted the nested-cat-assert branch June 4, 2024 05:59
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assert_series_equal with categorical_as_str does not work on nested Categoricals
2 participants