Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Column selection wasn't applied when reading CSV with no rows #16739

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jun 5, 2024

Fixes #16606

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.44%. Comparing base (ddf8126) to head (d64dde8).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/polars-io/src/csv/read/read_impl.rs 54.54% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16739      +/-   ##
==========================================
- Coverage   81.45%   81.44%   -0.02%     
==========================================
  Files        1413     1413              
  Lines      186096   186195      +99     
  Branches     2776     2776              
==========================================
+ Hits       151588   151650      +62     
- Misses      33988    34025      +37     
  Partials      520      520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review June 5, 2024 07:05
@ritchie46 ritchie46 merged commit 616b2e0 into pola-rs:main Jun 5, 2024
27 checks passed
@nameexhaustion nameexhaustion deleted the csv-projection-empty branch June 11, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

columns parameter from polars.read_csv not working on empty csv files
2 participants