Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove deprecated parameters in Series.cut/qcut and update struct field names #16741

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 5, 2024

Ref #13525

Changes

  • Removed the break_point_label, category_label, and as_series parameters from Series.cut/qcut
  • Updated the default struct names from brk and {name}_bin to breakpoint and category
  • Similarly, updated hist col name from break_point to breakpoint

These are unstable functions, so this is technically not breaking. But let's include it in the "breaking" category of the changelog to make it easier to find for people.

@github-actions github-actions bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 5, 2024
@stinodego stinodego changed the title feat!: Remove deprecated parameters in Series.cut/qcut feat(python,rust!): Remove deprecated parameters in Series.cut/qcut Jun 5, 2024
@github-actions github-actions bot added the breaking rust Change that breaks backwards compatibility for the Rust crate label Jun 5, 2024
@stinodego stinodego changed the title feat(python,rust!): Remove deprecated parameters in Series.cut/qcut feat!: Remove deprecated parameters in Series.cut/qcut Jun 5, 2024
@stinodego stinodego removed the breaking rust Change that breaks backwards compatibility for the Rust crate label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (a3f4ad9) to head (e585a18).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16741      +/-   ##
==========================================
- Coverage   81.43%   81.42%   -0.01%     
==========================================
  Files        1413     1413              
  Lines      186183   186153      -30     
  Branches     2776     2769       -7     
==========================================
- Hits       151615   151584      -31     
- Misses      34048    34050       +2     
+ Partials      520      519       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review June 5, 2024 08:59
@stinodego stinodego merged commit 5eb8931 into main Jun 6, 2024
31 checks passed
@stinodego stinodego deleted the cut-depr-remove branch June 6, 2024 01:42
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
@stinodego stinodego changed the title feat!: Remove deprecated parameters in Series.cut/qcut feat!: Remove deprecated parameters in Series.cut/qcut and update struct field names Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants