-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Default to coalesce=False
in left outer join
#16769
Conversation
ccbac35
to
7f688fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16769 +/- ##
==========================================
+ Coverage 81.29% 81.31% +0.01%
==========================================
Files 1424 1424
Lines 187205 187208 +3
Branches 2714 2713 -1
==========================================
+ Hits 152194 152233 +39
+ Misses 34514 34478 -36
Partials 497 497 ☔ View full report in Codecov by Sentry. |
b8dea60
to
80dcc03
Compare
CodSpeed Performance ReportMerging #16769 will degrade performances by 21.98%Comparing Summary
Benchmarks breakdown
|
This is going to be annoying when trying to convince the team to use polars. Have to explain that every time we have to do a left join, we need to add another parameter to avoid having _right columns all over |
Closes #13441
Changes
coalesce
behavior forjoin(how="left")
fromTrue
toFalse
.Example
Before:
After:
Use
coalesce=True
to get the previous behavior:Specifying
coalesce=True
is not required if the right column is never projected, as it will not be materialized. The following is equivalent to the code above: