Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python)!: Expedited removal of certain deprecated functionality (2) #16779

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 6, 2024

Ref #13525

Changes

  • Remove deprecated check_sorted parameter from ewm_by and rolling. This was only deprecated recently, but I'd rather not leave this useless parameter laying around. We made the same update for the other rolling functions.
  • Remove deprecated utc parameter from str.to_datetime.
  • Remove deprecated ambiguous parameter in dt.round.

@github-actions github-actions bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.32%. Comparing base (4d35be2) to head (9f1ccf0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16779      +/-   ##
==========================================
+ Coverage   81.29%   81.32%   +0.02%     
==========================================
  Files        1424     1424              
  Lines      187205   187198       -7     
  Branches     2714     2711       -3     
==========================================
+ Hits       152194   152231      +37     
+ Misses      34514    34470      -44     
  Partials      497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review June 6, 2024 14:55
@stinodego stinodego merged commit cee0e53 into main Jun 6, 2024
17 checks passed
@stinodego stinodego deleted the breaking-depr-last branch June 6, 2024 16:17
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jun 12, 2024
@stinodego stinodego changed the title feat(python)!: More removal of deprecated functionality feat(python)!: feat!: Expedited removal of certain deprecated functionality (2) Jun 12, 2024
@stinodego stinodego changed the title feat(python)!: feat!: Expedited removal of certain deprecated functionality (2) feat(python)!: Expedited removal of certain deprecated functionality (2) Jun 12, 2024
@github-actions github-actions bot added the breaking Change that breaks backwards compatibility label Jun 12, 2024
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jun 12, 2024
@github-actions github-actions bot added the breaking Change that breaks backwards compatibility label Jun 12, 2024
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jun 12, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant