Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support array arithmetic for equally sized shapes #16791

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

ritchie46
Copy link
Member

Later we can add trivial broadcasting with literals. Other broadcasting operations require more effort.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 18 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (4d35be2) to head (d11e417).
Report is 8 commits behind head on main.

Files Patch % Lines
crates/polars-core/src/series/series_trait.rs 14.28% 6 Missing ⚠️
...ates/polars-core/src/series/arithmetic/borrowed.rs 88.37% 5 Missing ⚠️
...es/polars-core/src/series/implementations/array.rs 80.00% 3 Missing ⚠️
crates/polars-core/src/series/mod.rs 0.00% 3 Missing ⚠️
crates/polars-core/src/datatypes/dtype.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16791      +/-   ##
==========================================
+ Coverage   81.29%   81.34%   +0.04%     
==========================================
  Files        1424     1424              
  Lines      187205   187264      +59     
  Branches     2714     2698      -16     
==========================================
+ Hits       152194   152327     +133     
+ Misses      34514    34441      -73     
+ Partials      497      496       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 31a20a6 into main Jun 6, 2024
26 of 27 checks passed
@ritchie46 ritchie46 deleted the array branch June 6, 2024 17:54
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants