Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Properly skip deltalake 0.18.0 for MacOS #16806

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 7, 2024

I messed up in #16803. I verified now that this works.

@stinodego stinodego added the skip changelog Do not include in changelog label Jun 7, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jun 7, 2024
@stinodego stinodego marked this pull request as ready for review June 7, 2024 13:21
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (f4549f1) to head (1805d22).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16806      +/-   ##
==========================================
+ Coverage   81.33%   81.39%   +0.05%     
==========================================
  Files        1424     1424              
  Lines      187172   187551     +379     
  Branches     2697     2696       -1     
==========================================
+ Hits       152235   152648     +413     
+ Misses      34441    34406      -35     
- Partials      496      497       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit aed60b9 into main Jun 7, 2024
15 checks passed
@stinodego stinodego deleted the fix-coverage-for-real branch June 7, 2024 13:42
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars skip changelog Do not include in changelog
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants