-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python)!: Update reshape
to return Array types instead of List types
#16825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking
Change that breaks backwards compatibility
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
labels
Jun 8, 2024
CodSpeed Performance ReportMerging #16825 will not alter performanceComparing Summary
|
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
June 9, 2024 15:05
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16825 +/- ##
==========================================
- Coverage 81.40% 81.38% -0.03%
==========================================
Files 1425 1425
Lines 187627 187638 +11
Branches 2702 2702
==========================================
- Hits 152738 152701 -37
- Misses 34393 34441 +48
Partials 496 496 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jun 10, 2024
ritchie46
reviewed
Jun 10, 2024
stinodego
force-pushed
the
reshape-array
branch
2 times, most recently
from
June 10, 2024 08:00
3e223ad
to
d4e7df0
Compare
ritchie46
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Change that breaks backwards compatibility
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14005
reshape
now returns an Array type instead of a List type.Users can restore the old functionality by calling
.arr.to_list()
on the output. Note that this is not more expensive than it would be to create a List type directly, because reshaping into an array is basically free.Example
Before:
After: