Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove inner Arc from FileCacheEntry #16870

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

nameexhaustion
Copy link
Collaborator

We already always wrap it in an Arc on the outside (Arc<FileCacheEntry>)

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jun 11, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review June 11, 2024 08:23
Copy link

codspeed-hq bot commented Jun 11, 2024

CodSpeed Performance Report

Merging #16870 will improve performances by 17.28%

Comparing nameexhaustion:file-cache-arc (db804dc) with main (84e2ea4)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main nameexhaustion:file-cache-arc Change
test_tpch_q14 2.5 ms 2.1 ms +17.28%

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.41%. Comparing base (0b0af39) to head (db804dc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16870      +/-   ##
==========================================
+ Coverage   81.33%   81.41%   +0.07%     
==========================================
  Files        1425     1425              
  Lines      187867   187926      +59     
  Branches     2702     2705       +3     
==========================================
+ Hits       152797   152994     +197     
+ Misses      34574    34436     -138     
  Partials      496      496              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 806feb5 into pola-rs:main Jun 11, 2024
22 checks passed
@nameexhaustion nameexhaustion deleted the file-cache-arc branch June 11, 2024 16:25
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants