Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement equality for more Array types #16902

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Jun 12, 2024

This PR adds more types of equality checks for different types of FixedSizeLists. There are two main areas remaining which are the Offset based arrays and the DictionaryArray.

This PR adds more types of equality checks for different types of `FixedSizeList`s. There are two many areas remaining which are the `Offset` based arrays and the `DictionaryArray`.
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 7.40741% with 50 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (2dba716) to head (f397ffa).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/polars-compute/src/comparisons/struct_.rs 0.00% 30 Missing ⚠️
crates/polars-compute/src/comparisons/null.rs 16.66% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16902      +/-   ##
==========================================
- Coverage   81.43%   81.00%   -0.44%     
==========================================
  Files        1425     1436      +11     
  Lines      187987   189056    +1069     
  Branches     2704     2704              
==========================================
+ Hits       153093   153144      +51     
- Misses      34397    35415    +1018     
  Partials      497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 12, 2024

CodSpeed Performance Report

Merging #16902 will degrade performances by 17.78%

Comparing coastalwhite:nested-array-eq (f397ffa) with main (cd68100)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main coastalwhite:nested-array-eq Change
test_groupby_h2oai_q2 5.3 ms 4.5 ms +17.59%
test_groupby_h2oai_q3 2.4 ms 2.8 ms -15.04%
test_tpch_q2 4.5 ms 5.5 ms -17.78%

@ritchie46 ritchie46 merged commit d6bf444 into pola-rs:main Jun 12, 2024
27 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
@stinodego stinodego changed the title feat(rust,python): add eq/ne for more FixedSizeLists feat(rust,python): Implement equality for more Array types Jun 30, 2024
@stinodego stinodego changed the title feat(rust,python): Implement equality for more Array types feat: Implement equality for more Array types Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants