Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Handle textio even if not correct #16971

Merged
merged 1 commit into from
Jun 15, 2024
Merged

feat(python): Handle textio even if not correct #16971

merged 1 commit into from
Jun 15, 2024

Conversation

ritchie46
Copy link
Member

fixes #13273

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jun 15, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 15, 2024

CodSpeed Performance Report

Merging #16971 will degrade performances by 17.52%

Comparing textio (967be51) with main (9a3e032)

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main textio Change
❌ test_tpch_q3 5.5 ms 6.6 ms -17.52%

@ritchie46 ritchie46 merged commit 9e3e9b0 into main Jun 15, 2024
25 of 26 checks passed
@ritchie46 ritchie46 deleted the textio branch June 15, 2024 11:19
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@ritchie46 @Wouittone
feat(python): Handle textio even if not correct (pola-rs#16971)
34f3225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polars panics when trying to read ndjson from a file-like object
1 participant
@ritchie46