feat(python)!: Change data orientation inference logic for DataFrame construction and warn when row orientation is inferred #16976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16818
Changes
DataOrientationWarning
. This attends the user that they are relying on 'implicit' behavior and that explicitly setting the orientation may be beneficial.This is a bit of a hit in ergonomics in favor of explicitness.
We can infer the data orientation in some cases but not others (e.g. when number of rows/columns is equal). This ended up with surprising behavior in certain cases (see linked issue).
Our solution is to issue a warning whenever row-orientation is inferred. The user must explicitly pass
orient="row"
to silence the warning.Example
Before:
After:
Use instead: