Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Desugar AND filter into multiple nodes #16992

Merged
merged 2 commits into from
Jun 16, 2024
Merged

perf: Desugar AND filter into multiple nodes #16992

merged 2 commits into from
Jun 16, 2024

Conversation

ritchie46
Copy link
Member

@alexander-beedie FYI. This should ensure the same performance as explicit nodes.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 16, 2024
@ritchie46 ritchie46 changed the title feat: Desugar AND filter into multiple nodes perf: Desugar AND filter into multiple nodes Jun 16, 2024
@github-actions github-actions bot added the performance Performance issues or improvements label Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (4ce4c6b) to head (b8fdf5e).
Report is 1 commits behind head on main.

Files Patch % Lines
...lars-plan/src/logical_plan/conversion/dsl_to_ir.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16992      +/-   ##
==========================================
+ Coverage   81.01%   81.04%   +0.02%     
==========================================
  Files        1446     1446              
  Lines      190425   190420       -5     
  Branches     2709     2709              
==========================================
+ Hits       154281   154322      +41     
+ Misses      35647    35601      -46     
  Partials      497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a81f6a5 into main Jun 16, 2024
21 checks passed
@ritchie46 ritchie46 deleted the desugar branch June 16, 2024 16:21
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants