Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand NDJson glob into one SCAN #17063

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

coastalwhite
Copy link
Collaborator

This properly expands globs in NDJson into one scan with multiple files.

This also fixes the n_rows parameter for DataFrame::scan_ndjson with multiple files.

This properly expands globs in NDJson into one scan with multiple files.
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (4d15fd4) to head (1419041).

Files Patch % Lines
...tes/polars-mem-engine/src/executors/scan/ndjson.rs 86.36% 3 Missing ⚠️
crates/polars-lazy/src/scan/ndjson.rs 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17063      +/-   ##
==========================================
- Coverage   80.89%   80.85%   -0.04%     
==========================================
  Files        1455     1455              
  Lines      190961   191011      +50     
  Branches     2723     2723              
==========================================
- Hits       154473   154450      -23     
- Misses      35984    36057      +73     
  Partials      504      504              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit df14d67 into pola-rs:main Jun 19, 2024
27 checks passed
@coastalwhite coastalwhite deleted the ndjson-scan-multiple-files branch June 19, 2024 10:29
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants