fix: Fix panic when using fold in certain situations
#17114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Fixes pola-rs#15444. This PR makes the `get_field` method of `GetOutput` fallible. Consequently, we can bubble up a lot more errors related to super typing instead of panicking. Although, I would normally add a test case here. I don't think this PR warrants one as the exact super typing behavior might be changed later.
coastalwhite
force-pushed
the
result-for-specialeq-supertype-15444
branch
from
231e10f
to
5dd3af7
Compare
ritchie46
approved these changes
Jun 22, 2024
stinodego
changed the title
GetOutput::get_field falliblefold in certain situations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15444.
This PR makes the
get_fieldmethod ofGetOutputfallible. Consequently, we can bubble up a lot more errors related to super typing instead of panicking.Although, I would normally add a test case here. I don't think this PR warrants one as the exact super typing behavior might be changed later.