-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add DSL validation for cloud eligible check #17287
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17287 +/- ##
==========================================
+ Coverage 80.70% 80.72% +0.01%
==========================================
Files 1485 1489 +4
Lines 195518 195628 +110
Branches 2782 2782
==========================================
+ Hits 157798 157924 +126
+ Misses 37208 37192 -16
Partials 512 512 ☔ View full report in Codecov by Sentry. |
1db40dc
to
e470aae
Compare
@ritchie46 I covered the cases I could think of - any other cases we should reject? I will rewrite this to a "prepare plan" util as discussed later - when I add the sink capability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We miss a few expressions.
@stinodego @c-peters here is the skeleton for the DSL cloud validation