Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add DSL validation for cloud eligible check #17287

Merged
merged 19 commits into from
Jul 16, 2024
Merged

refactor: Add DSL validation for cloud eligible check #17287

merged 19 commits into from
Jul 16, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jun 29, 2024

@stinodego @c-peters here is the skeleton for the DSL cloud validation

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 29, 2024
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 68.37607% with 37 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (c6e1d9e) to head (a297d25).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/polars-plan/src/client/dsl.rs 52.30% 31 Missing ⚠️
crates/polars-plan/src/client/mod.rs 82.85% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17287      +/-   ##
==========================================
+ Coverage   80.70%   80.72%   +0.01%     
==========================================
  Files        1485     1489       +4     
  Lines      195518   195628     +110     
  Branches     2782     2782              
==========================================
+ Hits       157798   157924     +126     
+ Misses      37208    37192      -16     
  Partials      512      512              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego changed the title feat: Add DSL validation for cloud eligible check refactor: Add DSL validation for cloud eligible check Jul 4, 2024
@github-actions github-actions bot added the internal An internal refactor or improvement label Jul 4, 2024
@stinodego stinodego marked this pull request as draft July 4, 2024 22:49
@stinodego stinodego self-assigned this Jul 8, 2024
@stinodego stinodego force-pushed the client branch 2 times, most recently from 1db40dc to e470aae Compare July 15, 2024 13:43
@stinodego
Copy link
Member

@ritchie46 I covered the cases I could think of - any other cases we should reject?

I will rewrite this to a "prepare plan" util as discussed later - when I add the sink capability.

@stinodego stinodego marked this pull request as ready for review July 16, 2024 00:17
Copy link
Member Author

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We miss a few expressions.

crates/polars-plan/src/client/mod.rs Show resolved Hide resolved
crates/polars-plan/src/client/mod.rs Outdated Show resolved Hide resolved
py-polars/src/cloud.rs Show resolved Hide resolved
@ritchie46 ritchie46 merged commit e74c0d5 into main Jul 16, 2024
27 checks passed
@ritchie46 ritchie46 deleted the client branch July 16, 2024 13:26
@c-peters c-peters added the accepted Ready for implementation label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants