Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Turn panic into error when serializing Object types #17353

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 2, 2024

These are not supported by design, so it should throw a nice error.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.46%. Comparing base (ad836bd) to head (46e91d1).
Report is 5 commits behind head on main.

Files Patch % Lines
crates/polars-core/src/serde/series.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17353      +/-   ##
==========================================
- Coverage   80.49%   80.46%   -0.03%     
==========================================
  Files        1483     1483              
  Lines      195010   195122     +112     
  Branches     2781     2781              
==========================================
+ Hits       156972   157012      +40     
- Misses      37527    37599      +72     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego force-pushed the serde-object-err branch 2 times, most recently from 0a6fb83 to 2ce0b74 Compare July 7, 2024 22:31
@stinodego stinodego marked this pull request as ready for review July 7, 2024 22:38
@stinodego stinodego marked this pull request as draft July 8, 2024 06:41
@stinodego stinodego marked this pull request as ready for review July 8, 2024 07:41
@stinodego stinodego self-assigned this Jul 8, 2024
@stinodego stinodego requested a review from ritchie46 July 8, 2024 08:34
@ritchie46 ritchie46 merged commit 4489fa8 into main Jul 8, 2024
26 checks passed
@ritchie46 ritchie46 deleted the serde-object-err branch July 8, 2024 09:28
henryharbeck pushed a commit to henryharbeck/polars that referenced this pull request Jul 8, 2024
@c-peters c-peters added the accepted Ready for implementation label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants