-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Turn panic into error when serializing Object types #17353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Bug fix
python
Related to Python Polars
rust
Related to Rust Polars
labels
Jul 2, 2024
ritchie46
reviewed
Jul 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17353 +/- ##
==========================================
- Coverage 80.49% 80.46% -0.03%
==========================================
Files 1483 1483
Lines 195010 195122 +112
Branches 2781 2781
==========================================
+ Hits 156972 157012 +40
- Misses 37527 37599 +72
Partials 511 511 ☔ View full report in Codecov by Sentry. |
stinodego
force-pushed
the
serde-object-err
branch
2 times, most recently
from
July 7, 2024 22:31
0a6fb83
to
2ce0b74
Compare
stinodego
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
July 7, 2024 22:38
stinodego
force-pushed
the
serde-object-err
branch
from
July 8, 2024 06:57
2ce0b74
to
46e91d1
Compare
ritchie46
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not supported by design, so it should throw a nice error.